Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SDL_MOUSE_TOUCH_EVENTS in touch test and docs #2484

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Use SDL_MOUSE_TOUCH_EVENTS in touch test and docs #2484

merged 3 commits into from
Oct 4, 2023

Conversation

MyreMylar
Copy link
Member

fixes #1182

@MyreMylar MyreMylar requested a review from a team as a code owner October 1, 2023 16:23
ankith26
ankith26 approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor related change suggestion for an issue observed while testing locally.

test/touch_test.py Outdated Show resolved Hide resolved
@ankith26 ankith26 added this to the 2.4.0 milestone Oct 1, 2023
ankith26
ankith26 reviewed Oct 1, 2023
View reviewed changes
test/touch_test.py Outdated Show resolved Hide resolved
zoldalma999
zoldalma999 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zoldalma999 zoldalma999 added the touch pygame.touch label Oct 4, 2023
@zoldalma999 zoldalma999 merged commit 07c26d4 into main Oct 4, 2023
31 checks passed
@ankith26 ankith26 deleted the sdl_mouse_touch branch October 4, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@zoldalma999 zoldalma999 zoldalma999 approved these changes

Assignees
No one assigned
Labels
touch pygame.touch
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

touchpad not giving FINGER events on MacOS Catalina SDL 2.0.10 and above (2309)
3 participants
@MyreMylar @zoldalma999 @ankith26