Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SDL_ConvertSurface(Format) for SDL3 #2500

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Fix SDL_ConvertSurface(Format) for SDL3 #2500

merged 1 commit into from
Oct 5, 2023

Conversation

Starbuck5
Copy link
Member

SDL3 just removes the unused flags argument, so it's very easy to port.

@Starbuck5 Starbuck5 requested a review from a team as a code owner October 5, 2023 05:18
@Starbuck5 Starbuck5 added Surface pygame.Surface sdl3 labels Oct 5, 2023
zoldalma999
zoldalma999 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the _sdl2.video module still uses SDL_ConvertSurface, but that is cython, so I think that can wait (and it will be ported off of it at some point anyway). LGTM

ankith26
ankith26 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@ankith26 ankith26 added this to the 2.4.0 milestone Oct 5, 2023
@ankith26 ankith26 merged commit efd2f1b into pygame-community:main Oct 5, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoldalma999 zoldalma999 zoldalma999 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
sdl3 Surface pygame.Surface
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Starbuck5 @zoldalma999 @ankith26