Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spurious comment in base __init__.py #2507

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Remove spurious comment in base __init__.py #2507

merged 1 commit into from
Oct 8, 2023

Conversation

Julian-O
Copy link
Contributor

@Julian-O Julian-O commented Oct 7, 2023

Comment referred to print statement requesting user-base support that has since been removed.

@Julian-O
Remove spurious comment
78f1b08 
Comment referred to spammy print statement requesting user support that has since been removed.
@Julian-O Julian-O requested a review from a team as a code owner October 7, 2023 12:02
MyreMylar
MyreMylar approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this seems fine to remove.

Temmie3754
Temmie3754 approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@Temmie3754 Temmie3754 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the history and the contribute link this comment was presumably about has since been removed so it makes sense to remove this too.

Matiiss
Matiiss approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@Matiiss Matiiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 490318d into pygame-community:main Oct 8, 2023
29 checks passed
@ankith26 ankith26 added this to the 2.4.0 milestone Nov 3, 2023
@ankith26 ankith26 changed the title Remove spurious comment Remove spurious comment in base __init__.py Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@Temmie3754 Temmie3754 Temmie3754 approved these changes

@Matiiss Matiiss Matiiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Julian-O @MyreMylar @Temmie3754 @Matiiss @ankith26