Add docs for "devicename" parameter in 'pygame.mixer.init()' #2525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usually I'd say "device" but I figured that would be kind of confusing. Writing just system with no specifier also seems very ambiguous. What system? |
MyreMylar
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed that this parameter wasn't documented so I asked around in the discord server to see what it does. You can use
pygame._sdl2.audio.get_audio_device_names()to get the valid names for it but since the module is hidden I just mentioned that it changes based on device. Maybe in a future PR we add a public function for it? It seems odd to have a parameter just dangle like this.