Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RLE usage in the transform module #2535

Merged
merged 20 commits into from
Nov 6, 2023
Merged

Fix RLE usage in the transform module #2535

merged 20 commits into from
Nov 6, 2023

Conversation

MyreMylar
Copy link
Member

@MyreMylar MyreMylar commented Oct 27, 2023

Building on work done in #2491. Don't merge this until that has gone in.

This makes sure we don't add the RLE flag to surfaces that didn't already have it before they were transformed. This was breaking output after transforms on color key surfaces - and there is no reason for us to be doing it.

fixes #1668

igordsm and others added 16 commits October 27, 2023 19:27
Co-authored-by: Joras <jorascco@al.insper.edu.br>
Co-authored-by: Antonio <antonioarf@al.insper.edu.br>
Co-authored-by: João <joaopga1@al.insper.edu.br>
Co-authored-by: Caio <caioesr@al.insper.edu.br>
Co-authored-by: Cícero <cicerotcv@al.insper.edu.br>
Co-authored-by: Natália <nataliaqmc@al.insper.edu.br>
function was added in 2.0.14 - min SDL version currently 2.0.9
@MyreMylar MyreMylar added the transform pygame.transform label Oct 27, 2023
@MyreMylar MyreMylar self-assigned this Oct 27, 2023
@MyreMylar MyreMylar marked this pull request as ready for review October 28, 2023 21:11
@MyreMylar MyreMylar requested a review from a team as a code owner October 28, 2023 21:11
@ankith26 ankith26 added this to the 2.4.0 milestone Oct 31, 2023
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a simple test case for this would be nice

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR! 🎉

(Needs a run of black on the test file to make the linter happy however)

PS: To the person merging this, please squash and merge (and remove any incorrect co-author tags too)

Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyreMylar MyreMylar merged commit c1618b3 into main Nov 6, 2023
30 checks passed
@MyreMylar MyreMylar deleted the fix-RLE-transform branch November 19, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transform pygame.transform
Projects
None yet
4 participants