Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setDaemon() deprecation error #2559

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Fix setDaemon() deprecation error #2559

merged 1 commit into from
Nov 12, 2023

Conversation

MyreMylar
Copy link
Member

Deprecated in Python 3.10.

.daemon is not a new attribute replacing .setDaemon() it is just now being put forth as the only way to set this attribute.

@MyreMylar
Fix setDaemon() deprecation error
4f392d2 
Deprecated in Python 3.10
@MyreMylar MyreMylar requested a review from a team as a code owner November 11, 2023 10:51
Starbuck5
Starbuck5 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should remove this module? (Not in this PR, but in general)

Anyways, this is an easy fix to approve, the daemon attribute was added in Python 2.6.

@Starbuck5 Starbuck5 added the Code quality/robustness Code quality and resilience to changes label Nov 12, 2023
ankith26
ankith26 approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 😎

@ankith26 ankith26 added this to the 2.4.0 milestone Nov 12, 2023
@ankith26 ankith26 merged commit 12be64b into main Nov 12, 2023
29 checks passed
@ankith26 ankith26 deleted the daemon-fix branch November 12, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MyreMylar @Starbuck5 @ankith26