Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for windows cameras without framerate #2574

Merged

Conversation

Starbuck5
Copy link
Member

Issue reported by Pallas's cat on discord.

pygame.error: Media Foundation HRESULT failure -1072875802 on camera_windows.c line 407

This should fix it, waiting on testing by them.

@Starbuck5 Starbuck5 requested a review from a team as a code owner November 19, 2023 20:51
@Starbuck5 Starbuck5 added Windows camera pygame.camera labels Nov 19, 2023
@Starbuck5 Starbuck5 force-pushed the fix-for-cameras-without-framerate branch from 6581bc0 to 8bad874 Compare November 19, 2023 20:52
@bilhox
Copy link
Contributor

bilhox commented Nov 19, 2023

With the fix, I get this new error :

  File "c:\Users\lodyB\OneDrive\Documents\workspace python\starbucks_pygame\examples\camera.py", line 47, in init_cams
    self.camera.start()
SystemError: <method 'start' of 'pygame.camera.Camera' objects> returned NULL without setting an exception

@Starbuck5
Copy link
Member Author

Makes sense...

Try this one:
pygame_ce-2.4.0.dev3-cp312-cp312-win_amd64.zip

@bilhox
Copy link
Contributor

bilhox commented Nov 19, 2023

Oh my god I'm so beautifu uh uh uh, excuse me, tyvm, it works correctly now !

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@dr0id dr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue for OP, and code LGTM. Thanks, let's get this in! 🎉

@ankith26 ankith26 added this to the 2.4.0 milestone Nov 21, 2023
@ankith26 ankith26 merged commit 0249f97 into pygame-community:main Nov 21, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
camera pygame.camera Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants