Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C loader targets a python alias #2586

Merged
merged 3 commits into from
Nov 24, 2023
Merged

C loader targets a python alias #2586

merged 3 commits into from
Nov 24, 2023

Conversation

pmp-p
Copy link
Member

@pmp-p pmp-p commented Nov 22, 2023

which is not yet available when using static loader.

Color = pygame.color.Color

@pmp-p pmp-p requested a review from a team as a code owner November 22, 2023 23:51
@yunline yunline added video pygame.video cython labels Nov 23, 2023
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Starbuck5
Copy link
Member

We still commit generated Cython, so I ran it with the changes in the PR and added a commit.

@pmp-p pmp-p merged commit 8d96c29 into main Nov 24, 2023
30 checks passed
@ankith26 ankith26 deleted the cython-static-load branch December 17, 2023 11:54
@ankith26 ankith26 added this to the 2.4.0 milestone Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cython video pygame.video
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants