Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linked/non linked SDL image version getter #2597

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Dec 10, 2023

It was reversed from what it should be.

Checked all the other version getters, this is the only one with the problem.

Noticed this when I built a pre release SDL_image 2.9 with SDL_image 2.8 headers and it reported itself as SDL_image 2.8.

@Starbuck5 Starbuck5 added the image pygame.image label Dec 10, 2023
@Starbuck5 Starbuck5 requested a review from a team as a code owner December 10, 2023 21:14
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing this mistake I accidentally made lol

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@ankith26 ankith26 added this to the 2.4.0 milestone Dec 11, 2023
@ankith26 ankith26 merged commit 8a446a2 into pygame-community:main Dec 11, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
image pygame.image
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants