Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Window to pygame.window.Window namespace #2604

Merged
merged 3 commits into from
Dec 16, 2023
Merged

Move Window to pygame.window.Window namespace #2604

merged 3 commits into from
Dec 16, 2023

Conversation

Starbuck5
Copy link
Member

Item 1 of #2603

@Starbuck5 Starbuck5 requested a review from a team as a code owner December 15, 2023 07:28
@Starbuck5 Starbuck5 added this to the 2.4.0 milestone Dec 15, 2023
MyreMylar
MyreMylar approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

yunline
yunline approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

ankith26
ankith26 approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@ankith26 ankith26 merged commit 353c0f5 into pygame-community:main Dec 16, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@yunline yunline yunline approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
window
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Starbuck5 @MyreMylar @yunline @ankith26