Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update always_on_top doc (it's not x11 only) #2618

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

Starbuck5
Copy link
Member

@Starbuck5 Starbuck5 commented Dec 20, 2023

The SDL2 docs say it is, but the SDL2 source has support for Mac/Windows/Linux. I tested it on Windows and it worked fine.

Relevant issue: #2603

Copy link
Contributor

@yunline yunline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reasoning behind marking it (X11 only) is that it does not work on something like direct wayland (and I just tested it to confirm)

@Starbuck5
Copy link
Member Author

I think the reasoning behind marking it (X11 only) is that it does not work on something like direct wayland (and I just tested it to confirm)

That is not the reasoning. The reasoning is that SDL says it is X11 only. The SDL docs are wrong. I've submitted a PR to their docs repo, but I expect it will be ignored (my last PR from 2021 has seen no action).

@Starbuck5
Copy link
Member Author

SDL merged my docs change! So this is updated on their end now as well.

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ankith26 ankith26 added this to the 2.4.0 milestone Dec 25, 2023
@ankith26 ankith26 merged commit 68c941b into pygame-community:main Dec 25, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants