Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pygame.image.load_sized_svg #2620

Merged
merged 5 commits into from
Dec 25, 2023
Merged

Implement pygame.image.load_sized_svg #2620

merged 5 commits into from
Dec 25, 2023

Conversation

ankith26
Copy link
Member

closes #2600

@ankith26 ankith26 requested a review from a team as a code owner December 20, 2023 11:55
Starbuck5
Starbuck5 reviewed Dec 21, 2023
View reviewed changes
docs/reST/ref/image.rst Outdated Show resolved Hide resolved
oddbookworm
oddbookworm approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nitpick that won’t prevent me from approving

docs/reST/ref/image.rst Outdated Show resolved Hide resolved
@Starbuck5 Starbuck5 added the image pygame.image label Dec 23, 2023
Starbuck5
Starbuck5 approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested this out locally, but everything seems straightforward enough.

Should the docs say "if not on SDL_image 2.6.0 or above, a pygame.error will be raised" ?

@ankith26 ankith26 added this to the 2.4.0 milestone Dec 25, 2023
@ankith26 ankith26 added the New API This pull request may need extra debate as it adds a new class or function to pygame label Dec 25, 2023
@ankith26 ankith26 merged commit cc1d5bf into main Dec 25, 2023
30 checks passed
@ankith26 ankith26 deleted the ankith26-sized-svg branch December 25, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
image pygame.image New API This pull request may need extra debate as it adds a new class or function to pygame
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

API proposal for scaled (svg) image loading
3 participants
@ankith26 @Starbuck5 @oddbookworm