Test function for pygame.draw.arc (resolves #2636) #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The circleci fail on this PR is not this PRs fault, don't worry. It's being resolved in another PR |
ankith26
reviewed
Jan 6, 2024
test/draw_test.py
Outdated
| self.assertEqual( | ||
| number_of_valid_arc_points, | ||
| number_of_invalid_arc_points + number_of_valid_arc_points, | ||
| ) |
There was a problem hiding this comment.
this check can more simply be written as self.assertEqual(number_of_invalid_arc_points, 0).
Additionally, we should probably test for number_of_valid_arc_points being correct somehow?
1 task
MyreMylar
reviewed
Feb 12, 2024
Comment on lines
+6173
to
+6174
| start = 0 | ||
| stop = 2 |
There was a problem hiding this comment.
I feel like we should probably test a broader range of arcs than just 0 to 2 radians, probably stuff like: pi, pi/2, pi/4, 2 * pi.
MyreMylar
reviewed
Feb 12, 2024
| "rect": rect, | ||
| "start_angle": start, | ||
| "stop_angle": stop, | ||
| "width": 1, |
There was a problem hiding this comment.
Probably should also test on wider range of widths than just 1.
MyreMylar
reviewed
Feb 12, 2024
MyreMylar
requested changes
Feb 12, 2024
|
Hi @Houda222, do you think you will make any of the changes asked for? Or should we pass this PR over to someone else to finish off? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves issue #2636
I added a test function
test_arc__correct_drawingthat replaced thetodo_test_arcfunction in theDrawArcMixinclass. It ensures thatpygame.draw.arcworks correctly, by checking whether the drawn arc matches the ellipse defined by the bounding rectangle. The comparison is done by measuring the difference between the ellipse's points and the arc's point and making sure it's less than a certain threshold.The test is done on different bounding rectangles.