Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HAVE_NEWBUF checks in tests #2640

Merged
merged 3 commits into from
Dec 30, 2023
Merged

Remove HAVE_NEWBUF checks in tests #2640

merged 3 commits into from
Dec 30, 2023

Conversation

ankith26
Copy link
Member

Just a minor code cleanup: HAVE_NEWBUF is a constant that is always defined to 1 in the source. So there's no need to check for it anymore

@ankith26 ankith26 requested a review from a team as a code owner December 28, 2023 18:20
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 simple change that makes the source tidier.

@zoldalma999 zoldalma999 added this to the 2.5.0 milestone Dec 30, 2023
@zoldalma999 zoldalma999 merged commit f42f761 into main Dec 30, 2023
30 checks passed
@ankith26 ankith26 deleted the ankith26-newbuf-check branch January 2, 2024 17:52
Starbuck5 pushed a commit that referenced this pull request Feb 18, 2024
@Starbuck5 Starbuck5 modified the milestones: 2.5.0, 2.4.1 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants