Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mp3 file-like object tests #2641

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Add mp3 file-like object tests #2641

merged 2 commits into from
Jan 4, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Dec 30, 2023 •
edited

fixes #2154

Apparently, the issue here is that mp3 file-like objects are not handled properly in SDL_mixer < 2.6.0 (which is what both our ubuntu builds are on ATM). So include these tests, but only if SDL_mixer is newer than 2.6.0

@ankith26 ankith26 requested a review from a team as a code owner December 30, 2023 06:49
MyreMylar
MyreMylar approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, seems odd that these only fail on linux CI, but if they've fixed it in SDL in the future then fine.

Starbuck5
Starbuck5 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I'm happy to get things like this resolved.

@Starbuck5 Starbuck5 added this to the 2.5.0 milestone Jan 4, 2024
@Starbuck5 Starbuck5 merged commit ff166fe into main Jan 4, 2024
29 checks passed
@Starbuck5 Starbuck5 deleted the ankith26-mp3-obj-test branch January 4, 2024 08:32
@Starbuck5 Starbuck5 added rwops SDL's IO loading/streaming code tests tests (module) mixer pygame.mixer labels Jan 4, 2024
Starbuck5 added a commit that referenced this pull request Feb 18, 2024
@Starbuck5
Merge pull request #2641 from pygame-community/ankith26-mp3-obj-test
ac0307b 
Add mp3 file-like object tests
@Starbuck5 Starbuck5 modified the milestones: 2.5.0, 2.4.1 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

Assignees
No one assigned
Labels
mixer pygame.mixer rwops SDL's IO loading/streaming code tests tests (module)
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Loading MP3 music from file like object fails on Linux
3 participants
@ankith26 @MyreMylar @Starbuck5