-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further deprecation of deprecated sprite groups #2666
Further deprecation of deprecated sprite groups #2666
Conversation
These things were always minor, but this is still a compatibility break. I don't think they should be removed. Updating docs and tutorials to not mention them is fine, seems like a good idea. |
I was just following the contents of the deprecation warnings, which were put there by MyreMylar. Also, I don't see that much harm in removing these particular groups, since they're just aliases, those few few people who actually use them and at some later point move over to pygame-ce can just do a find and replace and change the names to |
I didn't notice the deprecation warnings said that. That should be changed.
When you recommend someone switches over to pygame-ce, don't you want to be able say "it won't break your code" with the highest confidence? |
and clarifying the deprecation warning
Alright, added back the functional bits to maintain compatibility and changed deprecation warnings to just inform users that the features will be removed in a future version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense, thanks for the PR.
Further deprecation of deprecated sprite groups
Follow through of #2036