Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further deprecation of deprecated sprite groups #2666

Merged

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented Jan 14, 2024

Follow through of #2036

@Matiiss Matiiss added Code quality/robustness Code quality and resilience to changes sprite pygame.sprite labels Jan 14, 2024
@Matiiss Matiiss added this to the 2.5.0 milestone Jan 14, 2024
@Matiiss Matiiss requested a review from a team as a code owner January 14, 2024 15:46
@Starbuck5
Copy link
Member

These things were always minor, but this is still a compatibility break. I don't think they should be removed.

Updating docs and tutorials to not mention them is fine, seems like a good idea.

@Matiiss
Copy link
Member Author

Matiiss commented Jan 15, 2024

These things were always minor, but this is still a compatibility break. I don't think they should be removed.

Updating docs and tutorials to not mention them is fine, seems like a good idea.

I was just following the contents of the deprecation warnings, which were put there by MyreMylar. Also, I don't see that much harm in removing these particular groups, since they're just aliases, those few few people who actually use them and at some later point move over to pygame-ce can just do a find and replace and change the names to Group or that other group. Which obviously is less convenient than not having to do that, but we'd at some point remove them anyway (or at least should) and someone like that could still switch over after that happens and they'd have to do that find and replace thing anyway.

@Starbuck5
Copy link
Member

Starbuck5 commented Jan 15, 2024

I was just following the contents of the deprecation warnings, which were put there by MyreMylar

I didn't notice the deprecation warnings said that. That should be changed.

those few few people who actually use them and at some later point move over to pygame-ce can just do a find and replace and change the names to Group or that other group

When you recommend someone switches over to pygame-ce, don't you want to be able say "it won't break your code" with the highest confidence?

and clarifying the deprecation warning
@Matiiss Matiiss changed the title Removing deprecated sprite groups Further deprecation of deprecated sprite groups Jan 15, 2024
@Matiiss Matiiss removed the Code quality/robustness Code quality and resilience to changes label Jan 15, 2024
@Matiiss
Copy link
Member Author

Matiiss commented Jan 15, 2024

Alright, added back the functional bits to maintain compatibility and changed deprecation warnings to just inform users that the features will be removed in a future version.

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, thanks for the PR.

@Starbuck5 Starbuck5 merged commit ec5e6f8 into pygame-community:main Jan 30, 2024
30 checks passed
@Starbuck5 Starbuck5 added the docs label Jan 30, 2024
Starbuck5 added a commit that referenced this pull request Feb 18, 2024
Further deprecation of deprecated sprite groups
@Starbuck5 Starbuck5 modified the milestones: 2.5.0, 2.4.1 Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs sprite pygame.sprite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants