-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to SDL_image 2.8.2 #2674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if zlib1.dll
should be removed entirely? It is still not entirely clear if something else needs zlib, so potentially there could be a break on some systems where zlib isn't available outside?
Other things do rely on zlib, but they also have it statically. I believe libtiff is in this camp. None of the SDL lib prebuilts (which come with everything they need) contain an explicit zlib DLL right now, so I'm comfortable removing it. I didn't extricate from the build tooling yet, so it will look for zlib at build time with windows buildconfig and not find it, but that's 100% fine. |
So I was not feeling super confident, and I decided to fire a fresh windows VM to give this PR a spin, and got the classic error that everyone hates
More details: This is a fresh windows 11 with nothing else but python 3.12 installed. However when I do |
Okay so the same issue happens with 2.4.0 too |
I wonder if we could modify the test runner so it could tell us what module segfaulted, or even what function segfaulted. That would be much more handy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I figured that those fails are not really related to this PR at all, and this PR LGTM! Thanks 🎉
For completeness sake, this PR could also bump the SDL_image
on mac/manylinux, but I could also do it in a future PR if you say so.
This PR does that already :) |
Oh mb I didn't scroll down completely 🤦♂️ |
I updated the libpng in the SDL_image windows bundle, so this fixes #2650
Libpng now statically links to zlib, so the windows wheels no longer have any zlib DLL floating around.