Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduced redundancy in surface.fblits code and handled generator exception #2679

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Reduced redundancy in surface.fblits code and handled generator exception #2679

merged 2 commits into from
Jan 28, 2024

Conversation

Matiiss
Copy link
Member

@Matiiss Matiiss commented Jan 19, 2024

Somewhat of a continuation of #2667

@Matiiss Matiiss added Code quality/robustness Code quality and resilience to changes Surface pygame.Surface labels Jan 19, 2024
@Matiiss Matiiss requested a review from a team as a code owner January 19, 2024 11:22
itzpr3d4t0r
itzpr3d4t0r approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@itzpr3d4t0r itzpr3d4t0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

MyreMylar
MyreMylar approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Nice refactoring!

@MyreMylar MyreMylar merged commit 4682a1b into pygame-community:main Jan 28, 2024
30 checks passed
@ankith26 ankith26 added this to the 2.5.0 milestone Jan 29, 2024
@oddbookworm oddbookworm mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@itzpr3d4t0r itzpr3d4t0r itzpr3d4t0r approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes Surface pygame.Surface
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Matiiss @MyreMylar @itzpr3d4t0r @ankith26