Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing geometry versionadded tags #2709

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Add missing geometry versionadded tags #2709

merged 1 commit into from
Feb 9, 2024

Conversation

itzpr3d4t0r
Copy link
Member

The geometry module was still missing versionadded tags so I added them.

@itzpr3d4t0r itzpr3d4t0r added docs geometry pygame.geometry labels Feb 4, 2024
@itzpr3d4t0r itzpr3d4t0r requested a review from a team as a code owner February 4, 2024 12:52
MyreMylar
MyreMylar approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ankith26
ankith26 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking a single version added at the module level will do, but this works too, thanks for the PR 🎉

@itzpr3d4t0r itzpr3d4t0r added this to the 2.5.0 milestone Feb 9, 2024
@itzpr3d4t0r itzpr3d4t0r merged commit 3017133 into pygame-community:main Feb 9, 2024
2 checks passed
@itzpr3d4t0r itzpr3d4t0r deleted the add_missing_geometry_versionadded branch March 5, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
docs geometry pygame.geometry
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itzpr3d4t0r @MyreMylar @ankith26