Adapt test runner count tweak to be 3.12.1 only #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the revert commit: With the relevant changes being in this chunk here: Moving: ...before or after the skip test detecting block there that returns if a test is skipped. |
Starbuck5
added a commit
that referenced
this pull request
Feb 18, 2024
…verssion Adapt test runner count tweak to be 3.12.1 only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So when 3.12.1 released we had to add a tweak to our test running machinery because CPython stopped counting skipped tests as 'run'. Apparently this change has now been reverted for 3.12.2 (and 3.13) so we are back to how it was before.
This was causing our CircleCI runs to fail because that CI was grabbing the latest release of 3.12.2. I swear if they change this back again...