Reorganize geometry internals #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzpr3d4t0r
added
Code quality/robustness
itzpr3d4t0r
force-pushed
the
reorganize-geometry-internals
branch
from
9b563a2
to
e2c9987
Compare
oddbookworm
approved these changes
Mar 11, 2024
itzpr3d4t0r
force-pushed
the
reorganize-geometry-internals
branch
from
e762bab
to
300ad20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation PR to enable us to have functions like Rect/Frect.collidecircle() and in general interoperability with shapes. Specifically it fixes a circular import we had going on.
What this PR really does at a high level is moving some functions that need to get used by rects/circles/lines/polygons into a separate header file so that it can be included everywhere without circular imports.
Deleted:
Added:
Simplified: