Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipewire and libsamplerate+fftw3 #2733

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Add pipewire and libsamplerate+fftw3 #2733

merged 1 commit into from
Mar 19, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Mar 2, 2024

Follow up PR for #1997 but for audio stuff. (that PR should be merged first)

So, pipewire will most likely be the default audiodriver in SDL3, so it makes sense to add it early for testing purposes. Again, this does not affect any default behaviour in SDL2.

I'm also taking the opportunity to add libsamplerate support, this library is useful for improving sound quality on linux

@ankith26 ankith26 requested a review from a team as a code owner March 2, 2024 05:56
@ankith26 ankith26 force-pushed the ankith26-pipewire branch 3 times, most recently from 3c44d31 to e8beba7 Compare March 2, 2024 10:46
@Starbuck5
Copy link
Member

Just checked, libsamplerate is not in SDL3 FYI. (I know you didn't say it was, just informing you).

I checked the size of the wheels between this and the wheels produced for #1997 (a recent baseline, manylinux x86_64), and found the wheels are about ~16 kb bigger, which is suspiciously little for the addition of two new libraries.

@ankith26
Copy link
Member Author

I checked the size of the wheels between this and the wheels produced for #1997 (a recent baseline, manylinux x86_64), and found the wheels are about ~16 kb bigger, which is suspiciously little for the addition of two new libraries.

This is because only libsamplerate is being bundled, and it is a tiny library. pipewire is getting the dynamic load treatment, so apart from driver code on the SDL side, nothing else is being added

Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 8d6e7f9 into main Mar 19, 2024
29 checks passed
@ankith26 ankith26 added this to the 2.5.0 milestone Mar 21, 2024
@ankith26 ankith26 deleted the ankith26-pipewire branch March 21, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants