Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting updates using newest version of clang-format #2744

Merged
merged 2 commits into from
Mar 10, 2024

Conversation

oddbookworm
Copy link
Member

No description provided.

@oddbookworm oddbookworm added dependencies Formatting typos, grammar etc. labels Mar 9, 2024
@oddbookworm oddbookworm requested a review from a team as a code owner March 9, 2024 18:27
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR

@@ -38,8 +38,7 @@ ft_wrap_quit(pgFontObject *);
*
*********************************************************/
void
_PGFT_SetError(FreeTypeInstance *ft, const char *error_msg, FT_Error error_id)
{
_PGFT_SetError(FreeTypeInstance *ft, const char *error_msg, FT_Error error_id){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file are weird... but we will just go with whatever clang-format is doing here

@ankith26
Copy link
Member

ankith26 commented Mar 9, 2024

There seems to be a new mypy fail too, as it catches a real issue. Maybe that can be handled in this PR as well, just gotta add something like

def colorspace(
    surf: Surface, color: Literal["YUV", "HSV"], dest_surf: Surface = ..., /
) -> Surface: ...

to camera.pyi

@oddbookworm
Copy link
Member Author

There seems to be a new mypy fail too, as it catches a real issue. Maybe that can be handled in this PR as well, just gotta add something like

def colorspace(
    surf: Surface, color: Literal["YUV", "HSV"], dest_surf: Surface = ..., /
) -> Surface: ...

to camera.pyi

Updated. I also updated the doc signature to match

@MyreMylar MyreMylar merged commit be55232 into pygame-community:main Mar 10, 2024
30 checks passed
@ankith26 ankith26 added this to the 2.5.0 milestone Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Formatting typos, grammar etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants