-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pygame.threads #2762
Remove pygame.threads #2762
Conversation
2f3966c
to
6182c7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could deprecate it but not remove it just yet.
On a quick search I found atleast one github repo that uses it: https://github.com/pmtkachev/TMNT-Fight-NES/blob/c297f8aa9d802dc3fdbfc4b1b8726ccc95eeff97/src/game_func.py#L2
But they're not using the functionality! pygame.threads.Thread is a weird import of threading.Thread. They must've written thread and clicked "fix imports" and picked something from a list. No human would've written that unaided. This is an undocumented module that hasn't made any progress towards being a real thing since pygame 1.8.1, and has never been documented anywhere. The functionality is available in the standard library now. I say we pull the plug on the inevitable and just remove it. I don't see an undocumented experimental module that no one is actually using as being covered by any backwards compatibility concerns. |
Side note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay sure, let's remove this. Thanks for the PR 🎉
The source file doesn't seem to have had a non-linting related update in the past 7 years, it's not documented, and a scour of Google for mentions saw no one using it. I think this is safe to remove.
Also, unlike when this module was started, the standard library now has a way to do a threaded map, in the form of
ThreadPoolExecutor
.