Fix ftfont_test being run directly #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
added
the
Code quality/robustness
ftfont_test uses font_test to run, but it was trying to import pygame.freetype for a version check without an explicit import (which pygame.freetype needs). Removed the dependency on pygame.freetype for the ftfont path.
Starbuck5
force-pushed
the
fix-ftfont-test
branch
from
c6b2da8
to
dbcd9e2
Compare
oddbookworm
approved these changes
Mar 27, 2024
ankith26
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ftfont_test uses font_test to run, but it was trying to import pygame.freetype for a version check without an explicit import (which pygame.freetype needs). Removed the dependency on pygame.freetype for the ftfont path.
I ran into this while I was trying to get the old multithreaded test runner working, which runs each test in individual processes. This failed under those conditions. Normally something else imports pygame.freetype first so it's in working order by the time it gets here.