Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update freetype download link because current one is broken (fixes failing circleci builds) #2774

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Update freetype download link because current one is broken (fixes failing circleci builds) #2774

merged 1 commit into from
Mar 27, 2024

Conversation

ankith26
Copy link
Member

fixes #2773

@ankith26 ankith26 requested a review from a team as a code owner March 26, 2024 13:56
@ankith26 ankith26 changed the title Update freetype download link Update freetype download link because current one is broken (fixes failing circleci builds) Mar 26, 2024
@oddbookworm
Copy link
Member

I wonder if it would be feasible to set it up to try multiple mirrors in the case that the first one we try fails

oddbookworm
oddbookworm approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I still think it would be a good idea to maybe try multiple mirrors if the default one fails, but not a blocker for this pull IMO

@Starbuck5
Copy link
Member

LGTM! I still think it would be a good idea to maybe try multiple mirrors if the default one fails, but not a blocker for this pull IMO

This link is mirrored, try visiting it. I went 3 times and it sent me three different places.

@Starbuck5 Starbuck5 merged commit 8e87331 into main Mar 27, 2024
28 checks passed
@Starbuck5 Starbuck5 deleted the ankith26-freetype-download branch March 27, 2024 04:47
@Starbuck5 Starbuck5 added this to the 2.5.0 milestone Mar 27, 2024
@Starbuck5 Starbuck5 added dependencies CI Issue with the Continuous Integration (CI), the actions/bots that test things labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

Assignees
No one assigned
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things dependencies
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

build-freetype: http://download.savannah.gnu.org is busy or down
4 participants
@ankith26 @oddbookworm @Starbuck5 @cclauss