Fix sdist to include meson stuff and minor updates #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm though it looks like this is failing to build on Ubuntu 22.04.... probably in the meson build somewhere but we don't seem to get any logs for that just the ending. |
|
Fixed the issue by adding a pip upgrade |
Starbuck5
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures three files are bundled in our sdist wheels:
pyproject.toml,meson.buildandmeson_options.txt.With this change, anyone attempting an sdist install will be making use of the new buildconfig by default (though the old one can still be used with some flags or workarounds)
I also added excludes of files unneeded in sdist builds: pyc files, mypy cache files and mac ci files.