Support iterable in display.update
#2987
Open
+114
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-update-iterable
branch
from
ea9057d
to
83f6a4b
Compare
oddbookworm
approved these changes
Jul 13, 2024
ankith26
force-pushed
the
ankith26-update-iterable
branch
from
83f6a4b
to
e453cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2986 by adding
Iterablesupport indisplay.updateBefore someone points it out, yes it could potentially slightly lower performance, though I have done no benchmarking. There is scope for optimizing this function with our usual tricks though, i.e fastcall and list/tuple "fast sequence" special path, though I will leave that for future PRs.
Also this PR takes the opportunity to improve the tests for this function.