Fix break when the OS resizes our window in set_mode
#2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oddbookworm
added
Gnu/Linux
display
ankith26
reviewed
Jul 15, 2024
ankith26
reviewed
Jul 15, 2024
ankith26
reviewed
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #2991. I suspect that there's a lot I missed, so @robertpfeiffer @ankith26 @Starbuck5 please take a long look at these changes.
I haven't found a reliable way we can predict what the size the OS will force small windows to is, so I resorted to seeing what SDL says it is. Maybe I could just manually go through the event queue instead of pumping and grabbing the size from there?