Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Window.flash(operation) #3054

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

damusss
Copy link
Contributor

@damusss damusss commented Aug 13, 2024

Implements #3049.
Stubs, docs, tests included.
I chose the non-verbose constant names following SDL.

@damusss damusss added New API This pull request may need extra debate as it adds a new class or function to pygame window labels Aug 13, 2024
@damusss damusss requested a review from a team as a code owner August 13, 2024 09:42
@damusss damusss linked an issue Aug 13, 2024 that may be closed by this pull request
docs/reST/ref/window.rst Outdated Show resolved Hide resolved
src_c/window.c Outdated Show resolved Hide resolved
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@ankith26 ankith26 added this to the 2.5.2 milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New API This pull request may need extra debate as it adds a new class or function to pygame window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port SDL_FlashWindow
3 participants