Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test: surface.get_height() #1802

Closed
MyreMylar opened this issue May 18, 2020 · 1 comment
Closed

Add unit test: surface.get_height() #1802

MyreMylar opened this issue May 18, 2020 · 1 comment
Labels
easy An easy challenge to solve good first issue needs-tests Unit tests need writing python code This involves python code Surface pygame.Surface

Comments

@MyreMylar
Copy link
Contributor

This function needs a unit test.

Guide to how to contribute to an open source project on GitHub.
Draft guide on how to write a unit test for pygame

Test stub: https://github.com/pygame/pygame/blob/master/test/surface_test.py#L993-L1002
Docs: https://www.pygame.org/docs/ref/surface.html#pygame.Surface.get_height
Code to be tested: https://github.com/pygame/pygame/blob/master/src_c/surface.c#L2620-L2628
@MyreMylar MyreMylar added Surface pygame.Surface good first issue needs-tests Unit tests need writing python code This involves python code easy An easy challenge to solve labels May 18, 2020
@kduggan15 kduggan15 mentioned this issue May 21, 2020
Merged
@MightyJosip
Copy link
Contributor

This is now done thanks to the #1829 by @kduggan15. Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy An easy challenge to solve good first issue needs-tests Unit tests need writing python code This involves python code Surface pygame.Surface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MyreMylar @MightyJosip