Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Surface.get_height test #1829

Merged
merged 1 commit into from May 21, 2020
Merged

Adds Surface.get_height test #1829

merged 1 commit into from May 21, 2020

Conversation

kduggan15
Copy link
Contributor

Simplified pull request. Also added a few more test cases.
Issue: #1802
Original PR: #1823

MyreMylar
MyreMylar approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 🎉

illume
illume approved these changes May 21, 2020
View reviewed changes
Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@illume illume merged commit 9dcb80c into pygame:master May 21, 2020
@illume illume added the Surface pygame.Surface label May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
Surface pygame.Surface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kduggan15 @illume @MyreMylar