Fix bundle_docs.py issues #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the try-finally blocks to with statements to fix LGTM issues (LGTM info for pygame: https://lgtm.com/projects/g/pygame/pygame) - Changed print statements to be python 3 compatible - Fixed the list of root files to be included in the bundle - Other minor changes: docstrings/formatting/wording
dlon
reviewed
Aug 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes:
try-finallyblocks towithstatements to fix LGTM issues(LGTM info for pygame: https://lgtm.com/projects/g/pygame/pygame)
printstatements to be python 3 compatibleSystem details:
Resolves the bundle_docs.py issues from the LGTM link in #1133.