Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid character for surname in author comment #1473

Merged
merged 1 commit into from Oct 31, 2019
Merged

Fix invalid character for surname in author comment #1473

merged 1 commit into from Oct 31, 2019

Conversation

vilhelmprytz
Copy link
Contributor

The "ö" showed up as an invalid character. This has been replaced with a proper "ö". See attached image of how it showed up previously (I'm aware of the fact that GitHub interprets the invalid character correctly somehow).

Author in editor

The "ö" showed up as an invalid character. This has been replaced with a proper "ö".
@illume
Copy link
Member

illume commented Oct 31, 2019

Thanks :)

To understand this better, what did you change on that line? It looks the same to me.
What OS are you on, and which editor are you using?

With MacOS, and Sublime Text/vim it looks ok.

cheers,

@vilhelmprytz
Copy link
Contributor Author

I am on Ubuntu 18.04. The editor I was using was Visual Studio Code but it looked the same when using vim. I literally just replaced it with "ö" 😄

It's an odd one, looking at the diff generated by GitHub it looks like I've changed nothing at all. But on my local computer, git diff shows this.
pygame_git_diff

Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! David often uses Windows, and I think it's set the file to be encoded in "Western (Windows 1252)". I get the same diff as you when I set it to utf8.

Thanks again.

@illume illume merged commit 40902bd into pygame:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants