Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows dependency downloader: replaced requests with urllib #1493

Merged
merged 2 commits into from Nov 8, 2019
Merged

Windows dependency downloader: replaced requests with urllib #1493

merged 2 commits into from Nov 8, 2019

Conversation

MightyJosip
Copy link
Contributor

This should fix #1391.

@illume
Copy link
Member

illume commented Nov 8, 2019

Looks like python2 is confused...

    "__main__", fname, loader, pkg_name)
  File "C:\Python27\lib\runpy.py", line 72, in _run_code
    exec code in run_globals
  File "C:\projects\pygame\buildconfig\__main__.py", line 2, in <module>
    main()
  File "buildconfig\config.py", line 208, in main
    deps = CFG.main(**kwds)
  File "buildconfig\config_win.py", line 562, in main
    download_win_prebuilt.update(**download_kwargs)
  File "buildconfig\download_win_prebuilt.py", line 258, in update
    download_prebuilts(download_dir, x86=x86, x64=x64, sdl2=sdl2)
  File "buildconfig\download_win_prebuilt.py", line 107, in download_prebuilts
    download_sha1_unzip(url, checksum, temp_dir, 1)
  File "buildconfig\download_win_prebuilt.py", line 19, in download_sha1_unzip
    except ModuleNotFoundError:
NameError: global name 'ModuleNotFoundError' is not defined

Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@illume illume changed the title Replaced requests with urllib Windows dependency downloader: replaced requests with urllib Nov 8, 2019
@illume illume merged commit fbd00a9 into pygame:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build from source fails if you don't have requests installed on windows
2 participants