Added border_radius keyword for draw.rect and drawing of one circle quadrant, fixed bounding rects

[MightyJosip]

This should fix #895, #1120, #1122, #1153, #1212, #1241, #1305 and #1306

[illume]

Thanks @MightyJosip :)

[MightyJosip]

@charlesej since you did draw documentation, can you just check if I wrote it right, this is my first time I was writing docs and using rst files

[charlesej]

Your documentation looks good. I made a few minor comments.

One final note. When you are done making your changes to draw.rst, remember to run setup on the docs (python setup.py docs) to generate/update the draw_doc.h file.

[illume]

About quadrant=0-4... Is it confusing? I'm not sure if it's better than 0-3, and a default None for quadrant?

If kwargs were used (top_left, top_right, bottom_left, bottom_right) each defaulting to True, then it would make it possible from the API that different quadrants could be True and drawn at once. I'm not sure if that's desirable?

[illume]

@MightyJosip here's an example of usage you asked for.

Edit: here is how it looks using the quadrant argument.

    pygame.draw.circle(screen, BLUE, [250, 250], 40, 0, quadrant=1)
    pygame.draw.circle(screen, RED, [250, 250], 40, 30, 2, quadrant=2)
    pygame.draw.circle(screen, GREEN, [250, 250], 40, 20, quadrant=3)
    pygame.draw.circle(screen, BLACK, [250, 250], 40, 10, quadrant=4)

    # draw top left, bottom left slices of the circle.
    pygame.draw.circle(screen, BLACK, [250, 250], 40, 10, quadrant=1)
    pygame.draw.circle(screen, BLACK, [250, 250], 40, 10, quadrant=4)

Here is how it looks using the top, left, bottom, right args.

    pygame.draw.circle(screen, BLUE, [250, 250], 40, 0, top_left=True)
    pygame.draw.circle(screen, RED, [250, 250], 40, 30, 2, top_right=True)
    pygame.draw.circle(screen, GREEN, [250, 250], 40, 20, bottom_right=True)
    pygame.draw.circle(screen, BLACK, [250, 250], 40, 10, bottom_left=True)

    # draw top left, bottom left slices of the circle.
    pygame.draw.circle(screen, BLACK, [250, 250], 40, 10, bottom_left=True, top_left=True)

They should probably default to None, so that it is not required to call each one with False?
top_left=None, top_right=None, bottom_left=None, bottom_right=None

The only problem is that bottom_left, top_left doesn't read very well. It does not saying anything about what top_left refers to (drawing only the top_left quarter of the circle). Here's some other possible names...

• draw_top_left=True
• quad_tl=True
• quad_top_left=True
• ...

[illume]

Regarding:

it should be pretty trivial for me to make all corners different

Do you mean for the rounded corners?

In css they do let each corner be controlled with separate rules:

border-top-left-radius: 1px
border-top-right-radius: 2px
border-bottom-left-radius: 3px
border-bottom-right-radius: 4px

This way they have the default border-radius, and then each other rule can override that.
So it's possible to do (all corners 5px except top left at 10px):

border-radius: 5px
border-top-left-radius: 10px

[illume]

I updated the example usage comment above with the quadrant=, and top_left= styles to make comparison easier.

[MightyJosip]

With latest commit #1241, #1212, #1305, #1306, #1153 and #895 should also be fixed

[illume]

Thanks :)