Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip portmidi on Debian GNU/kFreeBSD and GNU/Hurd too #1545

Merged
merged 2 commits into from Jan 8, 2020
Merged

Skip portmidi on Debian GNU/kFreeBSD and GNU/Hurd too #1545

merged 2 commits into from Jan 8, 2020

Conversation

stefanor
Copy link
Contributor

@stefanor stefanor commented Dec 31, 2019 •
edited

Where on GNU/kFreeBSD:

>>> platform.system()
'GNU/kFreeBSD'

And on GNU/Hurd:

>>> platform.system()
'GNU'

Debian has been carrying a hacky patch to do this, but now that you're looking for FreeBSD, upstream, we can handle this better.

@stefanor stefanor changed the title Skip porttime on Debian GNU/kFreeBSD too Skip portmidi on Debian GNU/kFreeBSD and GNU/Hurd too Dec 31, 2019
illume
illume approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(I can't find where it talks about 'GNU' being a platform. I guess that's a freebsd + gnu debian patch to python)

@illume illume merged commit c6a04a3 into pygame:master Jan 8, 2020
@stefanor
Copy link
Contributor Author

stefanor commented Jan 8, 2020

I guess that's a freebsd + gnu debian patch to python.

FreeBSD kernel + GNU Userland

@stefanor stefanor deleted the kfreebsd branch January 8, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume approved these changes

Assignees
No one assigned
Labels
dependencies Platform: Debian
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stefanor @illume