New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI: Test Py38 on Ubuntu Bionic #1727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - though it might make sense to rebase/squash this to prune some of the intermediate commits.
Thanks. It would be good to have one builder using the new ubuntu. This way we can test with different versions of dependencies (like libsdl and such). Keeping other python versions in there lets us test with those older python versions too. The builds for python 3.8 for pygame 1.9.6 could be made, but that would have to be done manually by someone - not with our travis CI config. I guess pygame 2 will still take a while to do, and more and more people are encountering issues building from source. So we should probably do that. I'll squash-merge this into another branch, and do some more modifications on it in another PR. |
I'll have a look at this again after I push a release out in the next days :) |
@illume: Ping? |
Thanks for the ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Giving us good coverage of different systems and dependencies should be a goal for the CI. It seems Xenial reaches end of support next year in April 2021. https://wiki.ubuntu.com/Releases It would be good to cover these supported versions: (16.4, 18.4, 20.4, 20.10/Xenial, Bionic, Focal, Groovy). Keeping the older builds is required (because it helps us test with old versions of dependencies compared to dev machines which are often running on the latest). Running that ARM build on Xenial was required (maybe it still is). Because it would otherwise run on x86.
-
I haven't tested the config change at the bottom of the travis.yml (near deploy). What is the reason for the change?
Makes sense, thanks :) |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
The merge to master undid that. |
Related to #1429
sudo apt-get install musescore-soundfont-gm
fails on Ubuntu 20.04 so replace withtimgm6mb-soundfont
/usr/lib/gcc/x86_64-linux-gnu/9/include-fixed/bits/statx.h:38:25: error: missing binary operator before token "(" https://travis-ci.org/github/pygame/pygame/jobs/688841921#L1375