Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI: Test Py38 on Ubuntu Bionic #1727

Merged
merged 2 commits into from Sep 9, 2020
Merged

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented May 13, 2020

Related to #1429

  1. sudo apt-get install musescore-soundfont-gm fails on Ubuntu 20.04 so replace with timgm6mb-soundfont

  2. /usr/lib/gcc/x86_64-linux-gnu/9/include-fixed/bits/statx.h:38:25: error: missing binary operator before token "(" https://travis-ci.org/github/pygame/pygame/jobs/688841921#L1375

Copy link
Contributor

@nthykier nthykier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though it might make sense to rebase/squash this to prune some of the intermediate commits.

@illume
Copy link
Member

illume commented May 23, 2020

Thanks.

It would be good to have one builder using the new ubuntu. This way we can test with different versions of dependencies (like libsdl and such). Keeping other python versions in there lets us test with those older python versions too.

The builds for python 3.8 for pygame 1.9.6 could be made, but that would have to be done manually by someone - not with our travis CI config. I guess pygame 2 will still take a while to do, and more and more people are encountering issues building from source. So we should probably do that.

I'll squash-merge this into another branch, and do some more modifications on it in another PR.

@cclauss cclauss changed the title Travis CI: Test Py38 on Ubuntu 20.04 Travis CI: Test Py38 on Ubuntu Bionic May 24, 2020
@nthykier
Copy link
Contributor

@illume Any news on the branch you were talking about or should we go ahead and merge this one after it was squashed and rebased by @cclauss ?

@illume
Copy link
Member

illume commented May 30, 2020

I'll have a look at this again after I push a release out in the next days :)

@nthykier
Copy link
Contributor

nthykier commented Sep 5, 2020

I'll have a look at this again after I push a release out in the next days :)

@illume: Ping?

@illume
Copy link
Member

illume commented Sep 5, 2020

Thanks for the ping.

Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Giving us good coverage of different systems and dependencies should be a goal for the CI. It seems Xenial reaches end of support next year in April 2021. https://wiki.ubuntu.com/Releases It would be good to cover these supported versions: (16.4, 18.4, 20.4, 20.10/Xenial, Bionic, Focal, Groovy). Keeping the older builds is required (because it helps us test with old versions of dependencies compared to dev machines which are often running on the latest). Running that ARM build on Xenial was required (maybe it still is). Because it would otherwise run on x86.

  • I haven't tested the config change at the bottom of the travis.yml (near deploy). What is the reason for the change?

@cclauss
Copy link
Contributor Author

cclauss commented Sep 5, 2020

That change was made to fix a Travis Build Config Validation issue...
3C2CC6D1-E46C-42F2-81F4-6F80A7D735F4

@illume
Copy link
Member

illume commented Sep 9, 2020

Makes sense, thanks :)

@illume
Copy link
Member

illume commented Sep 9, 2020

skip_cleanup: true can be removed now since cleanup: false is the default.

Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks

@illume illume merged commit f4c2dd2 into pygame:master Sep 9, 2020
@cclauss cclauss deleted the patch-2 branch September 9, 2020 06:39
@cclauss
Copy link
Contributor Author

cclauss commented Sep 9, 2020

skip_cleanup: true can be removed now since cleanup: false is the default.

The merge to master undid that.
https://travis-ci.org/github/pygame/pygame/builds/725473713/config Click Build config validation

@illume illume added the ci Issue with the Continuous Integration (CI), the actions/bots that test things label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issue with the Continuous Integration (CI), the actions/bots that test things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants