Updating display.update() docs to reflect actual behaviour of SDL. #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about this one. Because the documented functionality of SDL_UpdateWindowSurfaceRects does not say it's a hint. (I saw Sam's comment). |
|
Ah, I see you submitted a patch to SDL for this not working on windows. Does it work fine on mac & linux then? If so then we should likely just leave the docs as they are and close the original bug once the SDL patch is merged. |
|
In my view, the alternative is to ask the SDL devs to update the documentation to reflect their view on that function. If we keep the status quo, then we will end up here eventually when pygame is used on a new platform that does not support that feature again. |
|
I'll switch this to draft for now so we don't accidentally merge it while there is uncertainty on the SDL position. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the 'rect' parameter is treated by SDL as a suggestion rather than a rule and platform implementations are ignoring it.
Related to:
#251