Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Surface.get_size test #1822

Merged
merged 3 commits into from May 20, 2020
Merged

Add Surface.get_size test #1822

merged 3 commits into from May 20, 2020

Conversation

PeanutbutterWarrior
Copy link
Contributor

Creates the test for #1810

@kduggan15 kduggan15 mentioned this pull request May 20, 2020
Closed
MyreMylar
MyreMylar suggested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I added some suggested changes below to try and make the test a bit more meaty.

Cheers,

test/surface_test.py Outdated Show resolved Hide resolved
PeanutbutterWarrior and others added 2 commits May 20, 2020 10:05
@PeanutbutterWarrior
Update test/surface_test.py
64efe09 
Adds more test cases

Co-authored-by: Dan Lawrence <danintheshed@gmail.com>
Add more test cases
7859e81
@PeanutbutterWarrior
Copy link
Contributor Author

Thanks, I've added them and some more

illume
illume approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@MyreMylar MyreMylar merged commit e593b44 into pygame:master May 20, 2020
@PeanutbutterWarrior PeanutbutterWarrior deleted the get_size-test branch May 24, 2020 11:03
@illume illume added the Surface pygame.Surface label May 29, 2020
@illume illume changed the title Add get_size test Add Surface.get_size test May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
Surface pygame.Surface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PeanutbutterWarrior @illume @MyreMylar