Try out some SDL1 tests for the overlay module. #1830
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overlay module is pretty neglected, probably because it doesn't exist in SDL2 but we have one issue open about it here:
#1199
And I ran across a potential porting guide here:
https://stackoverflow.com/questions/17579286/sdl2-0-alternative-for-sdl-overlay
So, I thought I'd see if I could get some tests going for SDL1 and see if it will at least work under SDL1.
DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats overlay.display(raw)
. I followed the guidance in this issue: DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats python-pillow/Pillow#3750 and made a few modifications to overlay.c to see if that will fix it.