display: Add support for controling screensaver state. part 2/2 #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nthykier
reviewed
May 23, 2020
|
Didn't you want to rename these functions? |
illume
force-pushed
the
sdl2-screensaver-support
branch
from
a548b02
to
bdee094
Compare
|
I pushed a change with the rename, and changed the default of |
nthykier
approved these changes
May 23, 2020
... on platforms that support it with SDL2. SDL2 does not provide any visible feedback on whether the controls have an effect and may "silently" say it changed the state without actually doing anything (except update the boolean variable, which `SDL_IsScreenSaverEnabled` returns). Accordingly, we document that these functions may be unreliable on certain platforms without any visible clue. For SDLv1, we just raise a `TypeError` as these functions are not supported there. Closes: #1707 Signed-off-by: Niels Thykier <niels@thykier.net>
illume
force-pushed
the
sdl2-screensaver-support
branch
from
bdee094
to
459d7b2
Compare
illume
force-pushed
the
sdl2-screensaver-support
branch
from
459d7b2
to
63b79f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing on #1734