Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mask.to_surface area tests #1854

Merged
merged 1 commit into from May 25, 2020
Merged

Add Mask.to_surface area tests #1854

merged 1 commit into from May 25, 2020

Conversation

charlesej
Copy link
Contributor

System details:

  • os: windows 10 (64bit)
  • python: 3.8.1 (64bit) and 2.7.10 (64bit)
  • pygame: 2.0.0.dev9 (SDL: 2.0.12) at 16a8d3e

Resolves the "test" item of "support for area kwarg" of #1070.

@charlesej charlesej added the mask pygame.mask label May 24, 2020
MyreMylar
MyreMylar approved these changes May 24, 2020
View reviewed changes
Copy link
Contributor

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

illume
illume approved these changes May 25, 2020
View reviewed changes
Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too :) Thanks.

@illume illume merged commit 12e671c into pygame:master May 25, 2020
@charlesej charlesej deleted the add-mask-to-surface-area-tests branch May 25, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illume illume illume approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
mask pygame.mask
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charlesej @illume @MyreMylar