Make saving image to BytesIO/StringIO work. Fix _pg_rw_write #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illume
reviewed
May 25, 2020
illume
reviewed
May 25, 2020
illume
requested changes
May 25, 2020
dangillet
force-pushed
the
1714_img_save_bytesio
branch
from
e8793b9
to
4ddb06e
Compare
illume
reviewed
May 25, 2020
Calling the helper write function should be done with a Bytes type instead of a String type for Python 3.
dangillet
force-pushed
the
1714_img_save_bytesio
branch
from
4ddb06e
to
e3bce7b
Compare
illume
approved these changes
May 26, 2020
illume
changed the title
robertpfeiffer
pushed a commit
to robertpfeiffer/pygame
that referenced
this pull request
Feb 15, 2023
…et-prebuilts Use prebuilt bundle hosted by us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1714
Calling the helper write function should be done with a Bytes type
instead of a String type.