setup.py cleanup: add -stripped build option to not include docs or tests #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We support python 2.7. At least until pygame 2 is released, at which point we can assess the situation again. |
illume
reviewed
May 30, 2020
illume
reviewed
May 30, 2020
illume
reviewed
May 30, 2020
illume
reviewed
May 30, 2020
illume
reviewed
May 30, 2020
illume
reviewed
May 30, 2020
setup.py
Outdated
| compilation_help() | ||
| raise SystemExit("Pygame requires Python3 version 3.5 or above.") | ||
| if IS_PYPY and sys.version_info < (3, 5): | ||
| raise SystemExit("Pygame requires PyPy compatible with Python 3.5 or above.") |
There was a problem hiding this comment.
Last I looked, pypy (the 2.7 equivalent) worked. Am I misunderstanding this message?
I guess we should find the exact pypy version that pygame supports 'well enough'?
There was a problem hiding this comment.
I haven't yet tested on PyPy 2.7, this might be a bit too conservative.
illume
reviewed
May 30, 2020
illume
reviewed
May 30, 2020
illume
requested changes
May 30, 2020
|
So what is left to be done here? |
illume
reviewed
Jun 23, 2020
illume
reviewed
Jun 23, 2020
illume
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.py is currently full of dead code, code that should be dead but is still reachable, and side effects.
This pull request removes handling of cases that should not happen any more, like no newbuffer support. Current versions of PyPy and CPython (3.5 and up) implement the buffer API, and older versions that don't are not supported. It's the same with setuptools.
Instead of handling the absence of these features, we should just return early on unsupported Python versions.
This pull request also adds a "-stripped" parameter, to be invoked like this:
python3 setup.py -stripped bdist_wheel. Stripped builds do not include any docs, tests, or code examples, so you can save space when embedding them in a binary distribution created with p4a or PyInstaller.These features are already part of the android branch, and by porting them over to
master, I hope we get closer to pointing the p4a build recipe to an official release tarball instead of a specialised version.