Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen warning in event docs about handling the event queue #1883

Merged
merged 2 commits into from Jun 4, 2020

Conversation

MyreMylar
Copy link
Contributor

For this issue:

#1392

If you don't call pygame.event.pump() somehow (it's called by pygame.event.get() by default) every frame your app's event handling is going to behave weirdly. I think the docs for pump() make this clear already but the warning in the main event module docs was a bit ambiguous.

docs/reST/ref/event.rst Outdated Show resolved Hide resolved
…and added extra warning about programs locking up
Copy link
Member

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks :)

@illume illume merged commit e3ad461 into pygame:master Jun 4, 2020
@MyreMylar MyreMylar deleted the strengthen-event-queue-limit-advice branch June 5, 2020 16:41
@illume illume added the docs label Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants