Testing mixer.music.play() start parameter & adding mp3 warning #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 1, 2020 09:03
…o the way timings are calculated for mp3 files.
…s files to disk slowly rather than playing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into this old issue:
#671
I discovered that the start parameter does work on linux & windows now, but after trying a couple of different mp3 files its 'seeking' accuracy with that file type depends on the file used. This is basically a difficulty with the mp3 file format itself, it includes no timing information so you have to guess based on the file size but doe to things like variable bit rate and tags applied to the file these guessed timings can be thrown off.
I thought the best way to resolve the issue was to add a unit test for the parameter using .ogg files which should be more reliable and add a note to the docs that indicates that for mp3s, the start time parameter is unreliable.