Account for big endian support for RGB/BGR images #1930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyreMylar
approved these changes
Jun 8, 2020
|
Probably, a good idea to get the other PR adding the big endian test machine to Travis merged, and then merge master into this PR to get useful data from CI. |
|
Sure, I can update it when the other PR is merged, or feel free to push to my branch. |
|
OK, the other PR is merged to master now. |
Add big endian blocks in image_frombuffer() for RGB and BGR images, similarly to how RGBA are handled. This also seems to match examples in SDL documentation. This fixes test_frombuffer_BGR and test_frombuffer_RGB on big endian machines (see pygame#1291).
|
Rebased now. |
|
Looks like it worked on Travis CI, I only see 1 error left there now 🎉 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add big endian blocks in image_frombuffer() for RGB and BGR images,
similarly to how RGBA are handled. This also seems to match examples
in SDL documentation. This fixes test_frombuffer_BGR
and test_frombuffer_RGB on big endian machines (see #1291).
Disclaimer: my big endian hardware is headless and I haven't looked at X forwarding yet, so I have no clue if this works correctly, or if both the tests and the code are doing it other way around ;-).