Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell this module is used exclusively for testing the real draw functions in
draw.c
. As such I was a little more ruthless in linting and tried to maintain only the function interfaces that were equivalent to thedraw.c
functions.The other problem with it is that there are lots of TODOs all over it that I didn't really want to get into. I feel like linting errors and fixing TODOs are two entirely different things that shouldn't really be jumbled together, as such I ran pylint with
fixme
disabled for this file.Disabled alerts:
This function is used to implement the interfaces of both
draw_line()
anddraw_aaline()
two functions that are already right at pylint's limit for function arguments, thus it wasn't really possible to cut the fat without splitting it into two functions - which would remove the point of having it all in one shared function in the first place.Remaining warnings after this PR (with fixme disabled)
0
Tested using:
pylint src_py/draw_py.py --extension-pkg-whitelist=pygame --disable=fixme