Add unit test to Clock.get_rawtime

[jiquach]

Closes #1786

Tests the logic:

• Clock initiation.
• get_rawtime()gets actual elapse time with a framerate argument in tick.
• get_rawtime() and get_time() return the same thing when there is no framerate argument.

[MyreMylar]

Looks good to me!

As with all the time module tests the delta value may end up needing to be tweaked for CI, but it's hard to tell without running it on CI lots of times.

Thanks for the contribution!

Appveyor is accidentally down at the minute so I won't merge this yet.

[illume]

This failed on one of the appveyor jobs...

======================================================================
FAIL: test_get_rawtime (pygame.tests.time_test.ClockTypeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\Python27-x64\lib\site-packages\pygame\tests\time_test.py", line 55, in test_get_rawtime
    self.assertAlmostEqual(delay_miliseconds, c1, delta=delta)
AssertionError: 100.0 != 117 within 15 delta

[jiquach]

@MyreMylar @illume Thanks for the reviews. I saw the AppVeyor test and saw that the common delta is 50 ms in the module. I will change that delta and rebase the branch.

[jiquach]

It seems that one of the AppVeyor jobs failed on a different test (test_get_fps). I checked out a couple of other AppVeyor builds and it seems that the specific test passes for those.

• Is there a way to kick off another AppVeyor build to confirm whether it is a valid issue to look into?
• The test_get_fps uses a 20% delta from the true FPS vs the calculated FPS from get_fps() which is large already so increasing the delta might make the test less concrete.

[illume]

Hi @jiquach thanks for mentioning the get_fps fail. I made a note about it at the issue here: #1785

The problem with the VMs and containers on highly loaded systems is that they can get very small time slices sometimes, and take quite a while to come back from sleeps. Making it pretty difficult to test timing related things.

[illume]

👍 🎉 thank you!